This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: Adds UI pivotFieldsets to UI Options #4265
Merged
a-b-r-o-w-n
merged 6 commits into
microsoft:main
from
tdurnford:feature/pivot-field-sets
Sep 30, 2020
Merged
feat: Adds UI pivotFieldsets to UI Options #4265
a-b-r-o-w-n
merged 6 commits into
microsoft:main
from
tdurnford:feature/pivot-field-sets
Sep 30, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
suggested changes
Sep 29, 2020
Contributor
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Let's make sure this gets added to the upstream ui schema definition as well.
a-b-r-o-w-n
approved these changes
Sep 30, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* pivot field sets * add jsx * updated type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
pivotFieldsetsto UI Options. When the ui options has afieldsetandpivotFieldis true, the fieldset is rendered in a tabbed view.This PR also updates the prompts ui-plugin to leverage
fieldsetsandadditionalFieldsinstead of custom fields.Task Item
Closes #3588