This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Unify skill and skill setting dispatchers #4173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
reviewed
Sep 18, 2020
srinaath
reviewed
Sep 18, 2020
srinaath
previously approved these changes
Sep 18, 2020
srinaath
previously approved these changes
Sep 18, 2020
srinaath
approved these changes
Sep 18, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 21, 2020
* main: fix: language err for build luis in azure deploy (microsoft#4155) fix: Unify skill and skill setting dispatchers (microsoft#4173)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setSettings: Modified the dispatcher to update theskillsStatewhen the settings are changedaddSkill,updateSkill,removeSkill: Updated the dispatchers to only set the skill's settings and not theskillStateupdateSkillsInSettings: Removed in favor ofupdateSkillTask Item
Closes #4172