This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feature: Adding VA template behind feature flag in Composer #4140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolum
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
pavolum
changed the title
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
GeoffCoxMSFT
reviewed
Oct 6, 2020
Composer/plugins/vacore/template/scripts/VAScripts/deploy_cognitive_models.ps1
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
previously approved these changes
Oct 6, 2020
Member
GeoffCoxMSFT
left a comment
GeoffCoxMSFT
left a comment
There was a problem hiding this comment.
Looks good to me, but you should have a more knowledgeable person with the plug-ins and templating approve before committing.
benbrown
reviewed
Oct 6, 2020
...ugins/vacore/template/scripts/DeploymentTemplates/function-template-with-preexisting-rg.json
Outdated
Show resolved
Hide resolved
benbrown
previously requested changes
Oct 6, 2020
Contributor
benbrown
left a comment
benbrown
left a comment
There was a problem hiding this comment.
There are some extraneous files here that should probably be removed.
Also, duplicating the boilerplate content is probably not good - we should make sure we ONLY include files that are NOT including in the boilerplate or runtime folders, and make sure they merge properly during creation. (/scripts folder, /schemas folder)
Composer/plugins/vacore/template/language-generation/en-us/general.en-us.lg
Show resolved
Hide resolved
hatpick
reviewed
Oct 6, 2020
cwhitten
suggested changes
Oct 8, 2020
cwhitten
approved these changes
Oct 12, 2020
cwhitten
dismissed
benbrown’s stale review
Ben this will be addressed with the upcoming conversational-core deliverable
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#4140) * Adding va core template plug in with corresponding plugin build steps * Adding env variable feature flag around VA=Core template * removing unused code that was initially added for custom runtime which has been removed * Updating react version in creation extension * Formatting template strings for localization Co-authored-by: Patrick Volum <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of a series of PRs for VA Creation in Composer. This PR covers the addition of the VA Core template to Composer behind an env variabe (VA_CREATION) feature flag. fixes #4142
To test, pull this branch, set the VA_CREATION env variable to true in the command line and run
yarn start:devin that same command line. This will result in 'va-core' appearing in the list of bot templates.At current state the VA template is functional in Composer and can run locally if you have preprovisioned LUIS and QNA resources that you can publish to.
NOTE: