Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: defense the usage of 'match()' method in skillsUtils #4110

Merged
a-b-r-o-w-n merged 4 commits into from
Sep 15, 2020
Merged

fix: defense the usage of 'match()' method in skillsUtils #4110

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcc0d3a
defense invocation of `value.match()`
yeze322 Sep 14, 2020
6abe24a
Merge branch 'main' into fix/4109
yeze322 Sep 14, 2020
edf4616
Merge branch 'main' into fix/4109
yeze322 Sep 15, 2020
5186de2
Merge branch 'main' into fix/4109
a-b-r-o-w-n Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Composer/packages/lib/shared/src/skillsUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ export const convertSkillsToDictionary = (skills: Skill[]) => {
return keyBy(mappedSkills, 'name');
};

export const getSkillNameFromSetting = (value: string) => {
export const getSkillNameFromSetting = (value?: string) => {
if (!value) return '';

const matched = value.match(/\['(.*?)'\]/);
if (matched && matched.length > 1) {
return matched[1];
Expand Down