This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Refer to settings.skill inside dialog files #4065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten and
tonyanziano
as code owners
srinaath
changed the title
srinaath
changed the title
beyackle
previously requested changes
Sep 9, 2020
Composer/packages/client/src/recoilModel/dispatchers/project.ts
Outdated
Show resolved
Hide resolved
Composer/packages/ui-plugins/select-skill-dialog/src/SkillEndpointField.tsx
Show resolved
Hide resolved
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Show resolved
Hide resolved
tdurnford
reviewed
Sep 9, 2020
tdurnford
reviewed
Sep 9, 2020
tdurnford
reviewed
Sep 9, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 9, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 9, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/SkillEndpointField.tsx
Show resolved
Hide resolved
added 11 commits
September 10, 2020 14:59
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
force-pushed
the
srravich/4032-skill-support
branch
from
9010204 to
0a1470d
Compare
tdurnford
reviewed
Sep 10, 2020
tdurnford
reviewed
Sep 10, 2020
tdurnford
reviewed
Sep 10, 2020
tdurnford
reviewed
Sep 10, 2020
tdurnford
reviewed
Sep 11, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 11, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 11, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/SelectSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 11, 2020
Composer/packages/ui-plugins/select-skill-dialog/src/SelectSkillDialogField.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Sep 11, 2020
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into feature/skill-support Signed-off-by: Srinaath Ravichandran <[email protected]> # Conflicts: # Composer/packages/server/src/models/bot/botProject.ts # Composer/packages/ui-plugins/select-skill-dialog/src/BeginSkillDialogField.tsx # Composer/packages/ui-plugins/select-skill-dialog/src/ComboBoxField.tsx # Composer/packages/ui-plugins/select-skill-dialog/src/SelectSkillDialogField.tsx # Composer/packages/ui-plugins/select-skill-dialog/src/__tests__/BeginSkillDialogField.test.tsx # Composer/packages/ui-plugins/select-skill-dialog/src/__tests__/SelectSkillDialog.test.tsx # Composer/packages/ui-plugins/select-skill-dialog/src/index.ts
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
tdurnford
previously approved these changes
Sep 11, 2020
Signed-off-by: Srinaath Ravichandran <[email protected]>
tdurnford
approved these changes
Sep 11, 2020
boydc2014
approved these changes
Sep 11, 2020
boydc2014
approved these changes
Sep 11, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR transforms settings.skill into a dictionary. We now let the BeginDialog action's id, skillAppId and skillEndpoint to refer to skills object inside settings. This makes sure that we have an expression instead of hardcoded values inside BeginDialog action
Fixes #4032