Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zxyanliu
Copy link
Contributor

@zxyanliu zxyanliu commented Sep 8, 2020

Description

As an experiment to refine texts in Composer UI.

  • For the new bot project form:
    Create a bot project
    Specify a name, description, and location for your new bot project.

  • For the new dialog form:
    Create a dialog
    Specify a name and description for your new dialog.

Task Item

closes #3952

Screenshots

e2e test in a draft PR:

image

image

image

@boydc2014
Copy link
Contributor

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

@coveralls
Copy link

coveralls commented Sep 8, 2020

Coverage Status

Coverage increased (+0.005%) to 55.494% when pulling 8bc7709 on zxyanliu/title-text/20200904 into f2a365a on main.

@zxyanliu zxyanliu changed the title doc: Update title of "new bot" dialog draft: update title of "new bot" dialog Sep 8, 2020
@liweitian
Copy link
Contributor

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

remove it should be fine. @zxyanliu @boydc2014

@zxyanliu
Copy link
Contributor Author

I reverted the commit to remove DEFINE_CONVERSATION_OBJECTIVE.
Let's not remove it for now.

@zxyanliu zxyanliu changed the title draft: update title of "new bot" dialog doc: update title of "new bot" dialog Sep 10, 2020
@zxyanliu zxyanliu marked this pull request as ready for review September 10, 2020 22:51
@a-b-r-o-w-n
Copy link
Contributor

@zxyanliu will this close #3952?

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 14, 2020
@zxyanliu
Copy link
Contributor Author

@zxyanliu will this close #3952?

@a-b-r-o-w-n Yes. Thanks!

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n merged commit 2315eeb into main Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the zxyanliu/title-text/20200904 branch September 14, 2020 16:01
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* draft

* Update constants.ts

* Revert "Update constants.ts"

This reverts commit cd473ff3e410a532cbd200518ced6509c8772852.

Co-authored-by: Andy Brown <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Approved to merge approved, waiting to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update title of "new bot" dialog

6 participants