Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Sep 7, 2020

Description

remove deprecated scripts in dotnet runtime template

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Sep 7, 2020

Coverage Status

Coverage remained the same at 55.494% when pulling b211ce7 on wenyluo/removeScript into 8d7187c on main.

@ltwlf
Copy link
Contributor

ltwlf commented Sep 7, 2020

I would not suggest to delete this scrip and rather improve or rewrite it. The current approach to deploy via UI is not sufficient for professionals. Additionally from IT security it is really bad. Customers need a build script for azure devops pipeline and must be able to define the secrets securely in Azure key vault.
I use/fix this script and going to use it for deployment / release via Azure pipelines for an enterprise customer. I can't imagine any enterprise customer using the deploy via UI publishing.

@ltwlf
Copy link
Contributor

ltwlf commented Sep 7, 2020

This PR fixes the azurewebapp deploy script #4050 and makes it ready for enterprise deployment. The other scripts are not needed, only deploy.ps1.

@VanyLaw
Copy link
Contributor Author

VanyLaw commented Sep 9, 2020

@ltwlf Thanks for the reminder. Because getting keys from "Azure key vault" is still in out todo list and have not been implemented yet. Considering the security, we should keep the deploy.ps1. because create.ps1 was replaced by provisionComposer.js script, so we will remove the rest deprecated scripts and take you fix.

@ltwlf
Copy link
Contributor

ltwlf commented Sep 10, 2020

@VanyLaw sounds good to me. I'm preparing a PR for optimizing the script for CI/CD deployment and a short readme. I think the readme is also outdated because running the bot directly (not directly via composer ui) will not generate/copy the dialogs.

@boydc2014
Copy link
Contributor

@VanyLaw can we just close this one?

@luhan2017 luhan2017 closed this Sep 16, 2020
@VanyLaw VanyLaw deleted the wenyluo/removeScript branch September 16, 2020 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants