Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: in setting botId not consistence with MicrosoftAppId #4052

Merged
cwhitten merged 4 commits into from
Sep 8, 2020
Merged

fix: in setting botId not consistence with MicrosoftAppId #4052

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b25a81c
auto fill `botId` with `MicrosoftAppId`
zhixzhan Sep 7, 2020
01b2e56
Merge branch 'main' into zhixzhan/setting-fix
zhixzhan Sep 8, 2020
2a8cac6
Merge branch 'main' into zhixzhan/setting-fix
a-b-r-o-w-n Sep 8, 2020
c43744f
Merge branch 'main' into zhixzhan/setting-fix
cwhitten Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Composer/packages/client/src/pages/skills/skill-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ const SkillSettings: React.FC<ISkillFormProps> = (props) => {
...skillSettings,
[event.target.id]: event.target.value,
};

// auto fill `botId` with `MicrosoftAppId`
if (event.target.id === 'MicrosoftAppId') {
localSettings.botId = event.target.value;
}

setSkillSettings({ ...localSettings });
console.log('ehh', localSettings);

@cwhitten cwhitten Sep 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

props.setSettings(props.projectId, { ...props.settings, ...localSettings });
};

Expand Down