This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: allows to define a custom static port with custom runtime command #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltwlf
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
ltwlf
changed the title
ltwlf
changed the title
ltwlf
changed the title
Contributor
Contributor
|
I like the proposed solution. I'm not sure exposing another "official" setting makes sense since those settings are getting written to the appsettings file and would then potentially affect non-local environments. |
a-b-r-o-w-n
approved these changes
Sep 8, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To setup a dev env to test bot skills with skill consumers locally. It is very useful to be able to define a static local port for a bot.
This PR allows to configure a custom port with -port 5000 in the custom runtime command. Without this PR the port gets always overwritten by the dynamic port finder.
e.g.
Start command*
dotnet run --port 5001 --project azurewebapp
Issue
fixes #4044