Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Jun 21, 2019

Changes:

  1. Align to current design
  2. Dialog based navigation
  3. LU intents been parsed and display with table view
  4. Prevent leave page when got unsaved changes.

Sample Bot Changes:

  1. ToDoLuisBot each dialog create a lu file.

Details:

  1. nav All have table view, show all lu intents in this bot. text edit mode is disabled, cause it's multiple files
  2. nav xxx-dialog have table view, show intents in this dialog. text edit can edit xxx-dialog.lu file.
  3. column Define in Been used actually show this intent belong to which xxx-dialog.lu and been used in xxx-dialog or not.

Preview:

preview

@zhixzhan zhixzhan changed the title [LU Page] lu all up view [LU Page] dialog-based LU all-up view and parsed intents Jun 21, 2019
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found a pretty gnarly bug. When adding a new dialog file, it wipes away the intents on the LU page except for the main. Then, if you jump into edit mode and save, all intents appear again, but they are doubled!

Steps to repro:

  1. Open LU page and notice the intents/dialogs
  2. Switch to visual page and create new dialog
  3. Go back to LU page and notice only the main lu file intents are shown
  4. Edit any LU file then save
  5. Click on "All"
  6. Notice all intents are back, but are now duplicated!

image

@a-b-r-o-w-n a-b-r-o-w-n self-requested a review June 25, 2019 17:35
allows user to switch bots and have separate luis config
@a-b-r-o-w-n
Copy link
Contributor

Couple of issues I've found:

  1. I am unable to publish the ToDoLuisBot sample due to empty lu files (Delete and Show). Adding a comment in them allows me to publish. The publish api is explicitly excluding empty files so I'm not sure what's going on here.
  2. The runtime throws this exception: System.Exception: Reference ToDoLuisBotlu could not be resolved.

@boydc2014
Copy link
Contributor

Couple of issues I've found:

  1. I am unable to publish the ToDoLuisBot sample due to empty lu files (Delete and Show). Adding a comment in them allows me to publish. The publish api is explicitly excluding empty files so I'm not sure what's going on here.
  2. The runtime throws this exception: System.Exception: Reference ToDoLuisBotlu could not be resolved.

#2 i think it's because the .lu.dialog is not generated, but we still refer to that in Recognizer.

@boydc2014
Copy link
Contributor

Add one comment from Marieke, we should get rid of the scroll bar of each intent, show all utterances at this version

@a-b-r-o-w-n
Copy link
Contributor

Add one comment from Marieke, we should get rid of the scroll bar of each intent, show all utterances at this version

Ok. I'll get this done today.

@a-b-r-o-w-n a-b-r-o-w-n dismissed their stale review June 26, 2019 17:51

new changes

@cwhitten cwhitten merged commit c04bf0f into master Jun 26, 2019
@cwhitten cwhitten deleted the zhixzhan/lu-page branch June 26, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants