Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Sep 1, 2020

Description

Cause: do luis build and luis publish even not luis bot in azurePublish plugin.
Solution: split lubuild and luis publish. Publishing luis when lu file not empty.

Task Item

close #3969

Screenshots

EchoBot can deploy without authoringKey.
image

@coveralls
Copy link

coveralls commented Sep 1, 2020

Coverage Status

Coverage remained the same at 56.747% when pulling ba2e20f on wenyluo/fix into 888f314 on main.

@luhan2017
Copy link
Contributor

I've tested this and found

  • it is working when no content in lu files and no luis.authoringKey configured.
  • there is an error when there is content in lu files and luis.authortingKey and endpointKey configured.
    image

I will work with Wenyi tomorrow to figure this out.

@luhan2017
Copy link
Contributor

There is a new issue that, then both luis and qna contents exist in the bot, sometimes the qna can be successfully published but sometime not, we have investigated and found the root cause is:

It is not recommended to use async and await in the forEach loop.
crossTrainResult.forEach(async (value, key) => {
const fileName = path.basename(key);
const newFileId = path.join(this.interruptionFolderPath, fileName);
await fs.writeFile(newFileId, value.Content);
});

we will update on both localPublish and azurePublish side on this.

@luhan2017 luhan2017 merged commit 8cb80f9 into main Sep 2, 2020
@luhan2017 luhan2017 deleted the wenyluo/fix branch September 2, 2020 08:29
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* split lubuild and luis publish

* polish

* change foreach to for, make sure writeFile async fucntion are done

* make write file parallel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Got an authentication error while the luis.authoringKey is not configured in the publish profile

3 participants