Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

feat: Design tweaks to Skill Manifest Generation Wizard#3864

Merged
cwhitten merged 2 commits intomicrosoft:mainfrom
tdurnford:feature/manifest-changes
Aug 19, 2020
Merged

feat: Design tweaks to Skill Manifest Generation Wizard#3864
cwhitten merged 2 commits intomicrosoft:mainfrom
tdurnford:feature/manifest-changes

Conversation

@tdurnford
Copy link
Collaborator

@tdurnford tdurnford commented Aug 19, 2020 •
edited by cwhitten
Loading

Description

  • Endpoints Step
    • Hide the protocol property since it can only be set to 'BotFrameworkv3' at the moment
      • There was a bug in the Adaptive Form package that didn't set the default/const for hidden properties. To resolve this, we shifted the responsibility for hiding fields from the ObjectField to the SchemaField where the default/const values are set.
  • Dialog Selection Step
    • Added a description column with an editable field to change the dialog description
    • Added a 'Select all' checkbox and hid the select all checkbox in the table
  • Select Trigger Step
    • Added a 'Select all' checkbox and hid the select all checkbox in the table

Task Item

closes #3333

Screenshots

Endpoints Step

image

Select Dialogs

image

Select Triggers Step

image

@coveralls
Copy link

coveralls commented Aug 19, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 56.967% when pulling 512a21b on tdurnford:feature/manifest-changes into f673648 on microsoft:main.

cwhitten
cwhitten reviewed Aug 19, 2020
View reviewed changes
Composer/packages/extensions/adaptive-form/src/utils/resolveRef.ts
definitions: { [key: string]: JSONSchema7Definition } = {}
): JSONSchema7 {
if (typeof schema?.$ref === 'string') {
if (!schema?.$ref?.startsWith('#/definitions/')) {
Copy link
Member

@cwhitten cwhitten Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this needed?

Copy link
Collaborator Author

@tdurnford tdurnford Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the refs in the Dialog Schema refer to 'http://json-schema.org/draft-07/schema#', so it throws the function throws an error since 'http://json-schema.org/draft-07/schema#' is not included in the definitions.

@cwhitten cwhitten merged commit 05e47eb into microsoft:main Aug 19, 2020
@tdurnford tdurnford deleted the feature/manifest-changes branch August 19, 2020 22:45
alanlong9278 added a commit that referenced this pull request Aug 20, 2020
@alanlong9278
Merge branch 'main' into qna-recognizer
d78e5ba 
* main:
  feat: enable js runtime (preview) (#3198)
  feat: Design tweaks to Skill Manifest Generation Wizard (#3864)
  feat: Update package to 4.10.0 and update schema and add samples for signoutuser  (#3862)
  fix lu inline update (#3861)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tdurnford
feat: Design tweaks to Skill Manifest Generation Wizard (microsoft#3864)
181da83 
* manifest generation changes

* fixed styling
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

improve skill manifest editing experience

3 participants

@tdurnford @coveralls @cwhitten