Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

draft: refactor the Trigger creation modal to be schema-driven #3832

Closed
yeze322 wants to merge 29 commits into from
Closed

draft: refactor the Trigger creation modal to be schema-driven #3832

yeze322 wants to merge 29 commits into from

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented Aug 12, 2020 •
edited
Loading

Description

closes #2889
(Refactoring. No functional changes.)

Ideally, the Trigger modal will be generated from sdk.uischema file.
This PR did some cleanup to evaluate the dev cost to achieve that goal.

Tricky problems

  • Trigger list is determined by current recognizer type. We may need an expression?
  • Trigger dropdown tree goes into uischema, Trigger form goes into widgets? refs issue 2889

Task Item

Screenshots

yeze322 added 15 commits August 11, 2020 15:43
@yeze322 yeze322 changed the title draft: refactor the Trigger creation modal to fit uischema requirements draft: refactor the Trigger creation modal to schema-driven Aug 12, 2020
@yeze322 yeze322 changed the title draft: refactor the Trigger creation modal to schema-driven draft: refactor the Trigger creation modal to be schema-driven Aug 12, 2020
@coveralls
Copy link

coveralls commented Aug 17, 2020

Coverage Status

Coverage increased (+0.5%) to 56.938% when pulling 34a6819 on yeze322:zeye/trigger-modal into 5ebecd7 on microsoft:main.

@yeze322
Copy link
Contributor Author

yeze322 commented Sep 10, 2020

due to QnA changes, created a new PR to track this problem #4079

@yeze322 yeze322 closed this Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ui plugin / ui schema for trigger creation modal

2 participants

@yeze322 @coveralls