This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: Gcox/merge from master 7 6 #3567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add logo-clicking to tests * bump elliptic version * Update yarn.lock Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix: support validate lg custom functions and separate the dialog validation from parser * use file name as namespace * add unit test * fix lint
* upgrade lu packages * update package * clean * update * clean up Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
…3517) Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
without this config, jest would only collect coverage on files that were imported in a test
…ad (#3523) * move AdaptiveForm components out of sub directory * show loading spinner while waiting for form data and schema Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
* allow input path * handle corner case * lint fix * fix the flicker issue * update UX and create or update folder operation * refine code structure * remove commented code * fix unit test * use esc to cancel operation * handle comments * handle comments * add test case * fix test case Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports
* + UT: adaptive-flow-renderer/widgets * + UT: adaptive-flow-editor/utils * remove unref hook: useWindowDimension * + UT: KeyboardZone * + UT: cursorTracker * + UT: adaptive-flow-editor/constants * +UT: AdaptiveFlowEditor * + UT: adaptive-flow-editor/contexts * + UT: useEditorEventApi * fix CI error * + UT: NodeWrapper * + UT: EdgeMenu * KeyboardZone behavioror test * change the test file structure of cursorTracker
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* issues#3309 * fixes lints * Default to bot settings if no route cache * fix: #3485 * fix: #3486 Debug/Fix HMR support * webpack bundle analyzer Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
* split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * split some actions off setSettings * add more actions - eject still not working * fix arguments in eject * Update setting.ts * fix some tests * Update index.ts * move logo-clicking to commands.ts * Update commands.ts
* fix: Dialog validate throw error when delete an action * use optional chaining and more explicit length check * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* fix bug * fix e2e test * fix bug
* Renamed components, hooks, Onboarding only * Reverting changed from yar build * Renamed components, hooks, Onboarding only * Reverting changed from yar build * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Renamed components, hooks, Onboarding only * Renamed components, hooks, Onboarding only * Fixing lint issues * test import fixes * Have to rename to fix case of file name * Fixing case with another commit. * Fixing imports * Index file renames Part 2
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
hatpick
approved these changes
Jul 6, 2020
GeoffCoxMSFT
removed request for
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging change from master
Task Item
#minor
Screenshots