Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@benbrown
Copy link
Contributor

@benbrown benbrown commented Jul 6, 2020

Description

Introduces the package library extension, an interface for discovering and managing packages that can be installed into your bot.

Task Item

Closes #3405

Screenshots

Screen Shot 2020-10-23 at 12 24 56 PM

@benbrown benbrown changed the base branch from master to main July 10, 2020 21:08
@a-b-r-o-w-n a-b-r-o-w-n added the 1.3 1.3 Release label Nov 13, 2020
@benbrown benbrown requested a review from yeze322 as a code owner November 13, 2020 17:34
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Nov 17, 2020
@coveralls
Copy link

coveralls commented Nov 18, 2020

Coverage Status

Coverage increased (+0.1%) to 54.649% when pulling 736ed73 on benbrown/importfromweb into 9c53186 on main.

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🎉

@benbrown benbrown merged commit 29aaf9e into main Nov 19, 2020
@benbrown benbrown deleted the benbrown/importfromweb branch November 19, 2020 19:40
EricDahlvang pushed a commit that referenced this pull request Nov 27, 2020
* add import endpoint

* ne dependency

* add support for getting a github project

* allow import from github

* fix issue with internal reference

* add support for nuget packages

* new deps

* semi-functional UI for importing assets from the web, some error checking, exciting stuff

* Ability to add, update, remove declarative libraries

* allow plugins to provide assets to appear in the library

* remove add route
:

* sample libs

* additional error handling

* allow categories of available libraries

* implement package manipulation using bf cli

* functioning install from npm or nuget

* exlcude version flag if not specified

* update to latest bf-dialog

* fix typos

* specify path to schema

* add confirmation if the merge process detects a conflict

* detect ejected

* update lockfile

* wrap test controller in editor extension

* [wip] move asset library into extension

* move some components into ui-shared

* add more apis to extension client

* add fabric to window

* fix build script

* disable if not ejected

* do not show installed list when disabled

* exit with error if error in any extensions

* add navigateTo to application context

* move asset library wholy into its own extension~

* use results of import/remove to update the ui instead of reprocessing

* merge master

* add confirm api to application context

* use the confirm api

* fix types resolution for sample-ui-plugin

* add recently used list to the asset library

* remove old version of library files

* aggregate all the UI strings at the top for ease of editing

* fix test

* add key field to default config

* show only compatible packages

* add missing field to test file

* yarn file

* finish merge

* refactor ui to use tabs

* learn more links

* add readme

* readme updates

* readme updates

* extract a few ui strings

* more readme

* more readme

* latest rc

* add key to runtime settings

* move extension context to server package

* update ExtensionContext imports

* pass extension context to ext manager

* fix server launch config

* move extension manager to server

* do not update lockfiles when building extensions

* do not pass extension context when loading

* remove unused import

* fix typescript error

* fix test failure

* add missing type imports

* remove duplicate property

* remove obsolete api

* add ExtensionRegistration type

* update extension references to ExtensionRegistration

* pass dataDir to registration

* use axios library instead of @types

* use same version of axios in types and client

* Update readme.md

fix grammatical error in "How to build your own packages" section header

* fix issue with extensions

* small adjustments due to extension boundary change

* fix test

* remove some unused code
remove feature flag for library
rename plugin to packageLibrary

* move strings into component. add types to internal state.

* Add cards to list of package features

* add instructions for using a JS custom action

* add typing for telemetry setting

* remove mocked enum

* fix main js

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Scott Gellock <scott.gellock@microsoft.com>
benbrown added a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* add import endpoint

* ne dependency

* add support for getting a github project

* allow import from github

* fix issue with internal reference

* add support for nuget packages

* new deps

* semi-functional UI for importing assets from the web, some error checking, exciting stuff

* Ability to add, update, remove declarative libraries

* allow plugins to provide assets to appear in the library

* remove add route
:

* sample libs

* additional error handling

* allow categories of available libraries

* implement package manipulation using bf cli

* functioning install from npm or nuget

* exlcude version flag if not specified

* update to latest bf-dialog

* fix typos

* specify path to schema

* add confirmation if the merge process detects a conflict

* detect ejected

* update lockfile

* wrap test controller in editor extension

* [wip] move asset library into extension

* move some components into ui-shared

* add more apis to extension client

* add fabric to window

* fix build script

* disable if not ejected

* do not show installed list when disabled

* exit with error if error in any extensions

* add navigateTo to application context

* move asset library wholy into its own extension~

* use results of import/remove to update the ui instead of reprocessing

* merge master

* add confirm api to application context

* use the confirm api

* fix types resolution for sample-ui-plugin

* add recently used list to the asset library

* remove old version of library files

* aggregate all the UI strings at the top for ease of editing

* fix test

* add key field to default config

* show only compatible packages

* add missing field to test file

* yarn file

* finish merge

* refactor ui to use tabs

* learn more links

* add readme

* readme updates

* readme updates

* extract a few ui strings

* more readme

* more readme

* latest rc

* add key to runtime settings

* move extension context to server package

* update ExtensionContext imports

* pass extension context to ext manager

* fix server launch config

* move extension manager to server

* do not update lockfiles when building extensions

* do not pass extension context when loading

* remove unused import

* fix typescript error

* fix test failure

* add missing type imports

* remove duplicate property

* remove obsolete api

* add ExtensionRegistration type

* update extension references to ExtensionRegistration

* pass dataDir to registration

* use axios library instead of @types

* use same version of axios in types and client

* Update readme.md

fix grammatical error in "How to build your own packages" section header

* fix issue with extensions

* small adjustments due to extension boundary change

* fix test

* remove some unused code
remove feature flag for library
rename plugin to packageLibrary

* move strings into component. add types to internal state.

* Add cards to list of package features

* add instructions for using a JS custom action

* add typing for telemetry setting

* remove mocked enum

* fix main js

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Scott Gellock <scott.gellock@microsoft.com>
benbrown added a commit that referenced this pull request Jun 11, 2021
* add import endpoint

* ne dependency

* add support for getting a github project

* allow import from github

* fix issue with internal reference

* add support for nuget packages

* new deps

* semi-functional UI for importing assets from the web, some error checking, exciting stuff

* Ability to add, update, remove declarative libraries

* allow plugins to provide assets to appear in the library

* remove add route
:

* sample libs

* additional error handling

* allow categories of available libraries

* implement package manipulation using bf cli

* functioning install from npm or nuget

* exlcude version flag if not specified

* update to latest bf-dialog

* fix typos

* specify path to schema

* add confirmation if the merge process detects a conflict

* detect ejected

* update lockfile

* wrap test controller in editor extension

* [wip] move asset library into extension

* move some components into ui-shared

* add more apis to extension client

* add fabric to window

* fix build script

* disable if not ejected

* do not show installed list when disabled

* exit with error if error in any extensions

* add navigateTo to application context

* move asset library wholy into its own extension~

* use results of import/remove to update the ui instead of reprocessing

* merge master

* add confirm api to application context

* use the confirm api

* fix types resolution for sample-ui-plugin

* add recently used list to the asset library

* remove old version of library files

* aggregate all the UI strings at the top for ease of editing

* fix test

* add key field to default config

* show only compatible packages

* add missing field to test file

* yarn file

* finish merge

* refactor ui to use tabs

* learn more links

* add readme

* readme updates

* readme updates

* extract a few ui strings

* more readme

* more readme

* latest rc

* add key to runtime settings

* move extension context to server package

* update ExtensionContext imports

* pass extension context to ext manager

* fix server launch config

* move extension manager to server

* do not update lockfiles when building extensions

* do not pass extension context when loading

* remove unused import

* fix typescript error

* fix test failure

* add missing type imports

* remove duplicate property

* remove obsolete api

* add ExtensionRegistration type

* update extension references to ExtensionRegistration

* pass dataDir to registration

* use axios library instead of @types

* use same version of axios in types and client

* Update readme.md

fix grammatical error in "How to build your own packages" section header

* fix issue with extensions

* small adjustments due to extension boundary change

* fix test

* remove some unused code
remove feature flag for library
rename plugin to packageLibrary

* move strings into component. add types to internal state.

* Add cards to list of package features

* add instructions for using a JS custom action

* add typing for telemetry setting

* remove mocked enum

* fix main js

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Scott Gellock <scott.gellock@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* add import endpoint

* ne dependency

* add support for getting a github project

* allow import from github

* fix issue with internal reference

* add support for nuget packages

* new deps

* semi-functional UI for importing assets from the web, some error checking, exciting stuff

* Ability to add, update, remove declarative libraries

* allow plugins to provide assets to appear in the library

* remove add route
:

* sample libs

* additional error handling

* allow categories of available libraries

* implement package manipulation using bf cli

* functioning install from npm or nuget

* exlcude version flag if not specified

* update to latest bf-dialog

* fix typos

* specify path to schema

* add confirmation if the merge process detects a conflict

* detect ejected

* update lockfile

* wrap test controller in editor extension

* [wip] move asset library into extension

* move some components into ui-shared

* add more apis to extension client

* add fabric to window

* fix build script

* disable if not ejected

* do not show installed list when disabled

* exit with error if error in any extensions

* add navigateTo to application context

* move asset library wholy into its own extension~

* use results of import/remove to update the ui instead of reprocessing

* merge master

* add confirm api to application context

* use the confirm api

* fix types resolution for sample-ui-plugin

* add recently used list to the asset library

* remove old version of library files

* aggregate all the UI strings at the top for ease of editing

* fix test

* add key field to default config

* show only compatible packages

* add missing field to test file

* yarn file

* finish merge

* refactor ui to use tabs

* learn more links

* add readme

* readme updates

* readme updates

* extract a few ui strings

* more readme

* more readme

* latest rc

* add key to runtime settings

* move extension context to server package

* update ExtensionContext imports

* pass extension context to ext manager

* fix server launch config

* move extension manager to server

* do not update lockfiles when building extensions

* do not pass extension context when loading

* remove unused import

* fix typescript error

* fix test failure

* add missing type imports

* remove duplicate property

* remove obsolete api

* add ExtensionRegistration type

* update extension references to ExtensionRegistration

* pass dataDir to registration

* use axios library instead of @types

* use same version of axios in types and client

* Update readme.md

fix grammatical error in "How to build your own packages" section header

* fix issue with extensions

* small adjustments due to extension boundary change

* fix test

* remove some unused code
remove feature flag for library
rename plugin to packageLibrary

* move strings into component. add types to internal state.

* Add cards to list of package features

* add instructions for using a JS custom action

* add typing for telemetry setting

* remove mocked enum

* fix main js

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Scott Gellock <scott.gellock@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.3 1.3 Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow import / management of asset libraries

5 participants