Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zidaneymar
Copy link
Contributor

Description

Fix an issue that the deploy process will get stuck at the zipping folder.

Task Item

fixes #3301

Screenshots

@coveralls
Copy link

coveralls commented Jul 1, 2020

Coverage Status

Coverage remained the same at 53.235% when pulling 1886831 on qika/fixDeploy into 9bd3ecd on master.

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Jul 1, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Jul 1, 2020
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Jul 1, 2020
@zidaneymar
Copy link
Contributor Author

@boydc2014 @VanyLaw
I find a way to resolve this issue without replacing the zipping library.
I remove the "@bfc/libs/bot-deploy": "../../packages/lib/bot-deploy" in package.json of azurePublish plugin, and everything starts to work fine, but not sure about the reason.
image

@boydc2014
Copy link
Contributor

@boydc2014 @VanyLaw
I find a way to resolve this issue without replacing the zipping library.
I remove the "@bfc/libs/bot-deploy": "../../packages/lib/bot-deploy" in package.json of azurePublish plugin, and everything starts to work fine, but not sure about the reason.
image

Good to see we don't have to replace a package without knowing the root cause.

@zidaneymar
Copy link
Contributor Author

zidaneymar commented Jul 2, 2020

Revert the previous commit and fix the path importing in azure publish plugin, previous style leads to an unexpetect behavior in zipping runtime process.

@lei9444
Copy link
Contributor

lei9444 commented Jul 2, 2020

I create an electron installer. But electron app can't load the azurePublish plugin. Maybe it's not a good solution

@boydc2014
Copy link
Contributor

I create an electron installer. But electron app can't load the azurePublish plugin. Maybe it's not a good solution

OK, @zidaneymar let's revert again back to use zip-folder and get the release out, then later figure out why archiver is not working.

@boydc2014
Copy link
Contributor

@cwhitten After digging into this issue whole day trying to figure out why previous "archiver" not working, Qi and Leilei located the issue is related to the way the package is referred, as Qi stated above, but simply change that will break Electron case. So Qi revert back again to use zip-folder.

I think this one is good to go now, we will leave the investigation later.

@hibrenda hibrenda mentioned this pull request Jul 2, 2020
6 tasks
@zidaneymar
Copy link
Contributor Author

close, have a better solution

@zidaneymar zidaneymar closed this Jul 3, 2020
@boydc2014
Copy link
Contributor

close, have a better solution

Can you link the better solution here?

@boydc2014
Copy link
Contributor

Close this in favor of #3536

@cwhitten cwhitten deleted the qika/fixDeploy branch July 10, 2020 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Approved to merge approved, waiting to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing -> Error: Only absolute URLs are supported

7 participants