Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: issue 3354 #3410

Closed
GeoffCoxMSFT wants to merge 2 commits into from
Closed

fix: issue 3354 #3410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a08190c
Changes Next to OK for new dialog creation
GeoffCox Jun 12, 2020
cad62d7
Updated tests to use 'OK' to find buttons
GeoffCox Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/__tests__/components/CreationFlow/DefineConversation/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('<DefineConversation/>', () => {
'schemaUrl%3Dhttps%3A%2F%2Fraw.githubusercontent.com%2Fmicrosoft%2Fbotframework-sdk%2Fmaster%2Fschemas%2Fcomponent%2Fcomponent.schema%26name%3DEchoBot-11299%26description%3DTest%20Echo',
};
const component = renderComponent();
const node = await component.findByText('Next');
const node = await component.findByText('OK');
fireEvent.click(node);
expect(onSubmitMock).toHaveBeenCalledWith({
description: 'Test Echo',
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/client/__tests__/components/CreationFlow/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('<CreationFlow/>', () => {

const component = renderComponent();
await navigate('create/Emptybot');
const node = await component.findByText('Next');
const node = await component.findByText('OK');
fireEvent.click(node);
});
});
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/CreationFlow/DefineConversation/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ const DefineConversation: React.FC<DefineConversationProps> = (props) => {
<PrimaryButton
data-testid="SubmitNewBotBtn"
disabled={hasErrors}
text={formatMessage('Next')}
text={formatMessage('OK')}
onClick={handleSubmit}
/>
</DialogFooter>
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/client/src/pages/design/createDialogModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const CreateDialogModal: React.FC<CreateDialogModalProps> = (props) => {
<PrimaryButton
data-testid="SubmitNewDialogBtn"
disabled={hasErrors}
text={formatMessage('Next')}
text={formatMessage('OK')}
onClick={handleSubmit}
/>
</DialogFooter>
Expand Down