This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: load lu content need add system locale #3281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
changed the title
a-b-r-o-w-n
approved these changes
Jun 3, 2020
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The defaultLanguage in luis setting is used as fallback local. And fallbacklocal is used to set default recognizer when we use multi language.
When we load the lu content, the local is used to check the file local.
lubuild will check the filename, if the filename is 'a.en-us.lu', the local will set to 'en-us'.
If the file name is 'a.lu', lubuild will use the passed local.
But if the file is 'a.en-us.lu', and the local is 'it-it', the function will throw an error.
Task Item
#minor
refs #3274
Screenshots