Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: suppress websocket error after connection lost #3270

Merged
a-b-r-o-w-n merged 7 commits into from
Jun 3, 2020
Merged

fix: suppress websocket error after connection lost #3270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23d7693
report bug template add `Electron`
zhixzhan Jun 2, 2020
4b50536
mute LSP WebSocket connection lost pop up error
zhixzhan Jun 2, 2020
527e6ba
refine re-connection
zhixzhan Jun 3, 2020
b23f4c2
use SendRequestWithRetry
zhixzhan Jun 3, 2020
28f2d92
Merge branch 'master' into zhixzhan/lsp-connection-error
zhixzhan Jun 3, 2020
8bb7ae1
Merge branch 'master' into zhixzhan/lsp-connection-error
cwhitten Jun 3, 2020
b79b1f5
Merge branch 'master' into zhixzhan/lsp-connection-error
a-b-r-o-w-n Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bot-framework-composer-bug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ assignees: ""

<!-- What browser are you using? -->

- [ ] Electron distribution
- [ ] Chrome
- [ ] Safari
- [ ] Firefox
Expand Down
9 changes: 7 additions & 2 deletions Composer/packages/lib/code-editor/src/LgEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ declare global {
async function initializeDocuments(lgOption: LGOption | undefined, uri: string) {
const languageClient = window.monacoLGEditorInstance;
if (languageClient) {
await languageClient.onReady();
languageClient.sendRequest('initializeDocuments', { uri, lgOption });
try {
await languageClient.onReady();
languageClient.sendRequest('initializeDocuments', { uri, lgOption });
} catch (error) {
// eslint-disable-next-line no-console
console.error('LSP WebSocket connection lost', error);
}
Comment thread
zhixzhan marked this conversation as resolved.
Outdated
}
}

Expand Down
9 changes: 7 additions & 2 deletions Composer/packages/lib/code-editor/src/LuEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,13 @@ function convertEdit(serverEdit: ServerEdit) {
async function initializeDocuments(luOption: LUOption | undefined, uri: string) {
const languageClient = window.monacoLUEditorInstance;
if (languageClient) {
await languageClient.onReady();
languageClient.sendRequest('initializeDocuments', { uri, luOption });
try {
await languageClient.onReady();
languageClient.sendRequest('initializeDocuments', { uri, luOption });
} catch (error) {
// eslint-disable-next-line no-console
console.error('LSP WebSocket connection lost', error);
}
}
}

Expand Down