This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: update bot naming rules #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
Contributor
|
Can you take the chance to add some test into this, at least to this validation function? |
Contributor
|
LGTM, but I agree this could use some simple unit tests. |
liweitian
force-pushed
the
validateBotName
branch
from
d81fc8b to
2149b84
Compare
Contributor
Author
|
test cases added |
a-b-r-o-w-n
suggested changes
May 28, 2020
Composer/packages/client/__tests__/components/CreationFlow/DefineConversation/index.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/__tests__/components/createDialogModal.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/__tests__/components/createDialogModal.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/TriggerCreationModal.tsx
Outdated
Show resolved
Hide resolved
liweitian
force-pushed
the
validateBotName
branch
from
02cbcc2 to
fc06849
Compare
a-b-r-o-w-n
suggested changes
May 29, 2020
Composer/packages/client/__tests__/components/createDialogModal.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/__tests__/components/createDialogModal.test.tsx
Outdated
Show resolved
Hide resolved
liweitian
force-pushed
the
validateBotName
branch
from
6c6ab91 to
ef636d9
Compare
a-b-r-o-w-n
previously approved these changes
Jun 1, 2020
Member
|
@liweitian please address conflicts |
liweitian
force-pushed
the
validateBotName
branch
from
ef636d9 to
b914081
Compare
a-b-r-o-w-n
approved these changes
Jun 2, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* update naming rule * update dialog and trigger naming rule * add unit tests * lint fix * handle comments * handle comments * rebase * fix test case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not allow using dot in bot's dialog and trigger name.
Task Item
Closes #3185
Screenshots