This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Fixed expression array styling #3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
beyackle
previously approved these changes
May 26, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
This change looks good, but at some later point I want to come back to what's going on with types like string | false | undefined on that label prop. I'm sure it works, but it looks weird.
Collaborator
Author
|
@beyackle Yes, I agree - the
|
cwhitten
approved these changes
May 26, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fixed styling * fixed styling * lint fix Co-authored-by: TJ Durnford <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the 'Validation Rules' array styling so the expression expands to use the full width of the property editor and errors render below the text field instead of next to it.
Task Item
Closes #3187
Screenshots