Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: add settings file ignore #3179

Merged
cwhitten merged 9 commits into from
May 29, 2020
Merged

fix: add settings file ignore #3179

cwhitten merged 9 commits into from
May 29, 2020

Conversation

@VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented May 25, 2020

Description

add appsettings.json ignore in root project. In order to prevent file be mis-uploaded.

Task Item

close #3105

Screenshots

cwhitten
cwhitten previously requested changes May 25, 2020
View reviewed changes
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VanyLaw I believe the intention was to add to the .gitignore of the generated bot directory, so that the appsettings.json doesn't inadvertently get checked in.

@VanyLaw
Copy link
Contributor Author

VanyLaw commented May 26, 2020

Hi @cwhitten I add gitignore file into our sample bot folder, so when user create a new bot, it will include the gitignore file. But it can only take effect in new bot. Do you think is it necessary to check the gitignore file existed or not in code when bot opened?

@boydc2014
Copy link
Contributor

boydc2014 commented May 27, 2020

Hi @cwhitten I add gitignore file into our sample bot folder, so when user create a new bot, it will include the gitignore file. But it can only take effect in new bot. Do you think is it necessary to check the gitignore file existed or not in code when bot opened?

@VanyLaw , please use the feature of BoilerPlate, you just need to add one .gitignore in plugins/samples/assets/shared, it will be copied to generated bot

boydc2014
boydc2014 previously requested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@boydc2014 boydc2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@boydc2014 boydc2014 self-assigned this May 27, 2020
@VanyLaw
Copy link
Contributor Author

VanyLaw commented May 28, 2020

Hi @cwhitten I add gitignore file into our sample bot folder, so when user create a new bot, it will include the gitignore file. But it can only take effect in new bot. Do you think is it necessary to check the gitignore file existed or not in code when bot opened?

@VanyLaw , please use the feature of BoilerPlate, you just need to add one .gitignore in plugins/samples/assets/shared, it will be copied to generated bot

Got it, Thank you for reminding me.

@a-b-r-o-w-n a-b-r-o-w-n requested review from boydc2014 and cwhitten May 29, 2020 15:32
@a-b-r-o-w-n a-b-r-o-w-n dismissed stale reviews from cwhitten and boydc2014 May 29, 2020 15:33

stale

@cwhitten cwhitten merged commit 895db7c into master May 29, 2020
@cwhitten cwhitten deleted the wenyluo/3105 branch May 29, 2020 16:32
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Jun 3, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@VanyLaw @a-b-r-o-w-n @cwhitten
fix: add settings file ignore (microsoft#3179)
0a80605 
* add settings file ignore

* add gitignore in sample bot folder

* remove gitignore into boilerPlate

* add luis sample ignore back

* remove useless gitignore

Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

2 more reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@boydc2014 boydc2014

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Projects appsettings.json file checked in by default

5 participants

@VanyLaw @boydc2014 @cwhitten @a-b-r-o-w-n