This repository was archived by the owner on Jul 9, 2025. It is now read-only.
refactor: clean some code #3155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
beyackle
suggested changes
May 21, 2020
Composer/packages/server/src/models/storage/localDiskStorage.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Nice to see the cleanup. Can you take the chance to add more UT in the code you touched here if possible. |
Contributor
Author
added UT to test delete all files function |
beyackle
approved these changes
May 27, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* clean some code * add test case and rmrfDir interface * code style Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Dong Lei <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use rimraf to replace deleteFilesFrombottomToUp
Task Item
#minor
Screenshots