This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: show all error messages in log #3129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanyLaw
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
Contributor
|
What is an example of an object error? Can we do better than simply stringifying it? |
beyackle
reviewed
May 19, 2020
Contributor
Author
It can be a Errror or other object type exception. If error is a simple object type exception, we need to stringify it before we put into log. |
beyackle
reviewed
May 20, 2020
beyackle
approved these changes
May 21, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
Looks good to me - there is some more cleanup that could happen here, but it's a small and important enough change that I won't block it on that.
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* show error message in log * fix comments * fix comments Co-authored-by: Ben Yackley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
push all the error into log.
Task Item
close #3087
Screenshots