-
Notifications
You must be signed in to change notification settings - Fork 374
build: update typescript, eslint, prettier and more #3125
Conversation
Keep this as a JS module to reduce compile steps, but at least consumers get type info
packages can include their own babel config instead
|
This is a huge set of file diffs to look through - am I correct that the biggest changes here are to put parentheses around function arguments (e.g. |
|
@beyackle You are correct. You are also in luck, the alphabetized props already groups event handlers edit: the parens for arrow functions is now a prettier default. The reasoning is that it makes it easier to 1) add additional parameters and 2) add param typing. Also, the vast majority of changes to src files were |
|
@beyackle I'm open to discuss new / changes to eslint rules. With respect to sorting props, I like that you don't have to think about it -- every prop has its place! |
|
Giving it some more thought, I think I agree with the alphabetized props. It's one fewer way code can be changed without changing its meaning. If we decide it's too annoying, we can revert that part. |
beyackle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automated changes look pretty good, but there are a few small things I think still need to be changed.
Composer/packages/client/src/components/ProjectTree/treeItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/dialog-settings/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/store/persistence/FileOperation.ts
Outdated
Show resolved
Hide resolved
beyackle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚢
closes #2570