fix: Fix start bot in windows #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
7 tasks
cwhitten
approved these changes
May 3, 2020
|
Verified this is good functionally. |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2870
We introduced some enhancement for process management in #2861, which is not compatible with Windows, causing publishing request never return in Windows and the page eventually crashed in page.
This PR fix the local runtime management plugin by bring back previous behavior with a guard isWin, to be able to behave a little different than Mac.