Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: regEx trigger creation bug #2214

Merged
a-b-r-o-w-n merged 2 commits into from
Mar 10, 2020
Merged

fix: regEx trigger creation bug #2214

a-b-r-o-w-n merged 2 commits into from
Mar 10, 2020

Conversation

@liweitian
Copy link
Contributor

@liweitian liweitian commented Mar 10, 2020 •
edited by cwhitten
Loading

Description

  1. Delete the regEx pattern when we delete the trigger which triggers it.
  2. Do not allow user to create an onIntent trigger when the recognizer type is None.

Task Item

closes #2215

Screenshots

aaaaa
aaaaa1

@a-b-r-o-w-n a-b-r-o-w-n changed the title fix: regEx creation bug fix: regEx trigger creation bug Mar 10, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit d5f1776 into microsoft:master Mar 10, 2020
@cwhitten cwhitten mentioned this pull request Mar 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

1 more reviewer

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liweitian @a-b-r-o-w-n @cwhitten