This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: support copy actions across dilaogs #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
cwhitten
approved these changes
Mar 9, 2020
7 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
Users can't copy actions across different dialog files. If they copied some actions and pasted to another dialog file, nothing would happen.
Solution:
This PR fixes that issue by handling errors when the copy lg api invocation failed.
Context:
This bug is related to recent lg file structure changes. Previously, we only have one lg file 'common.lg', but for now, each dialog file has a default lg file, makes our
copyLgTemplateapi won't work if user wants to copy a template from 'Main.lg' to 'Todo.lg'.As I discussed with Zhixiang, it's quite complicated to deal with cross-file lg template copying problem because LG template could be nested. In this PR, visual editor only defenses potential LG copy failures to make sure the functionality 'copy selection' always work even no lg content will be copied. Compared to 'nothing will be copied', 'copy actions without lg' sounds an acceptable quick fix.
Task Item
fixes #2199
Screenshots