-
Notifications
You must be signed in to change notification settings - Fork 374
fix: deployment script, decouple debugging and deployment settings #2153
Conversation
Use appsettings.Deployment.json for local debug, use appsettings.Production.json for azure deployment.
|
@zidaneymar can you elaborate on the design of decoupling appsetttings.json into dev.json and prod.json? a few questions is
anyhow, let's get time to address those, and i put an onhold on this one in case accidentally merged. |
|
| `bin/Debug/${envSettings.runtimeFrameworkVersion}/BotProject.dll`, | ||
| `--urls`, | ||
| this.endpoint, | ||
| `--environment`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the protocol to add a new parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the protocol to add a new parameter
dotnet receive the env parameter to determine whether it's under development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this param will be sent to 'dotnet run' iteself, not a botproject level param.
https://stackoverflow.com/questions/50821504/asp-net-core-set-hosting-environment-in-build-process
Description
fix #2007
Task Item
Screenshots