This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: Use header tag for trigger in visual editor #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
benbrown,
boydc2014,
cwhitten and
yeze322
as code owners
yeze322
suggested changes
Feb 28, 2020
Contributor
yeze322
left a comment
yeze322
left a comment
There was a problem hiding this comment.
What Ashish described in the issue by saying 'defined under heading tag' should be using <h1>/<h2>/<hi> instead of using span
alanlong9278
changed the title
Contributor
Author
Fixed it. |
yeze322
approved these changes
Mar 2, 2020
cwhitten
approved these changes
Mar 4, 2020
cwhitten
changed the title
corinagum
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use header tag for trigger in visual editor
Task Item
fixes #2028
Screenshots