This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: repaint ui for setProperties in visual editor #2017
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
840cdbe to
874417f
Compare
yeze322
reviewed
Feb 22, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 24, 2020
Composer/packages/extensions/visual-designer/src/widgets/ChoiceInput.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 24, 2020
Composer/packages/extensions/visual-designer/src/widgets/ChoiceInput.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 24, 2020
Composer/packages/extensions/visual-designer/src/widgets/PropertiesWidget.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 24, 2020
Composer/packages/extensions/visual-designer/src/widgets/PropertiesWidget.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
The styled component lib could help us standardize the design langauge we used in Visual Editor. It's a really good change. We will migrate to the styled lib in future PRs. |
yeze322
reviewed
Feb 25, 2020
Composer/packages/extensions/visual-designer/src/components/nodes/templates/FormCard.tsx
Outdated
Show resolved
Hide resolved
5 tasks
yeze322
suggested changes
Feb 26, 2020
Contributor
yeze322
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeze322
reviewed
Feb 27, 2020
...oser/packages/extensions/visual-designer/src/components/nodes/templates/ListOverviewCard.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 27, 2020
Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx
Outdated
Show resolved
Hide resolved
yeze322
suggested changes
Feb 27, 2020
Contributor
yeze322
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to reduce changes, improve code quality.
Composer/packages/extensions/visual-designer/src/components/elements/styledComponents.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/widgets/ListOverviewWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/widgets/ListOverviewWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/widgets/ListOverviewWidget.tsx
Outdated
Show resolved
Hide resolved
...oser/packages/extensions/visual-designer/src/components/nodes/templates/ListOverviewCard.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 27, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 27, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 28, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 28, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 28, 2020
yeze322
reviewed
Feb 28, 2020
Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 28, 2020
Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 28, 2020
Composer/packages/extensions/visual-designer/src/components/common/ListOverview.tsx
Outdated
Show resolved
Hide resolved
yeze322
approved these changes
Mar 2, 2020
cwhitten
approved these changes
Mar 3, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Repaint ui for
setPropertieswith new design in visual editor.What does this pr do?
Extract


listOverviewcomponent.Like the pics show, the list in
setPropertiesandmultiInputis the same ui except the itemRender.So, we can extract
listOverviewand through sending renderFunciton to render different item list.Define the elements as styledComponents
Depends on new design, there are 4 types styled compoments. The element components can change the color by props.
Span

SingleLineDiv

MultiLineDiv

BorderedDiv

LinkBtn

setProperties,ChoiceInputwith elements.LinkBtn(elements) indialogRefnode.What's next?
Add templateElement into element libs.
Refactor
formCardto support new design.(Ze is doing)Combine with the layout pr written by ze.
Rewrite the node ui with new design.
Task Item
fixes #1701
Screenshots