This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: support inline LU section editing #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
zhixzhan
changed the title
liweitian
reviewed
Feb 17, 2020
liweitian
reviewed
Feb 17, 2020
Composer/packages/client/src/pages/language-understanding/code-editor.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I've been playing with this, looks good, except one issue In inline lu mode, the auto-completion is only complete for entity definition for "this part", but what we really want is complete for all entities defined in this lu file(and the imported ones). @cosmicshuai can you also help take a look |
Contributor
Sure. I will look into it. |
yeze322
reviewed
Feb 25, 2020
Composer/packages/client/src/pages/language-understanding/code-editor.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Feb 25, 2020
Composer/packages/tools/language-servers/language-understanding/package.json
Show resolved
Hide resolved
boydc2014
approved these changes
Feb 25, 2020
Contributor
boydc2014
left a comment
boydc2014
left a comment
There was a problem hiding this comment.
LGTM now, @cwhitten @a-b-r-o-w-n
a-b-r-o-w-n
approved these changes
Feb 25, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for LU inline editing in form, visual, we need implement Inline-LU Editor base on recently integrated LU LSP.
Inline features:
Task Item
close #1980
Screenshots
Simple section editing:
Nested section editing:
Inline highlighting & suggestion
