This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: show error message in form editor. #1737
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
suggested changes
Dec 9, 2019
Contributor
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor feedback. I will do a functional test today.
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Couple more things:
|
a-b-r-o-w-n
suggested changes
Dec 9, 2019
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
previously approved these changes
Dec 9, 2019
Contributor
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanlong9278 I think this is good to go. Can you test more scenarios today?
I did find a couple of things unrelated to this change: #1742 #1744
efbf7b2 to
c3fffd6
Compare
Contributor
Author
I have tested different scenarios, it runs well. |
Contributor
Author
|
@a-b-r-o-w-n There are two items changed.
|
This was referenced Dec 10, 2019
zhixzhan
reviewed
Dec 10, 2019
Composer/packages/extensions/obiformeditor/src/Form/widgets/LgEditorWidget.tsx
Outdated
Show resolved
Hide resolved
zhixzhan
reviewed
Dec 10, 2019
Composer/packages/extensions/obiformeditor/src/Form/widgets/LgEditorWidget.tsx
Show resolved
Hide resolved
boydc2014
approved these changes
Dec 10, 2019
7 tasks
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Sync diagnostics info with notification page in form editor, includes lg, lu and expression dianostics.
Task Item
closes #1699
closes #1715
Type of change
Please delete options that are not relevant.
Checklist
Screenshots