This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: Align with the new design in form for inline error display #1683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
suggested changes
Dec 2, 2019
Contributor
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this scale to all other form fields? We are not surfacing errors outside of the expression widget, but what happens when we do?
Composer/packages/extensions/obiformeditor/src/Form/fields/PromptField/PromptSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/fields/PromptField/PromptSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ObjectFieldTemplate/styles.css
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/fields/PromptField/PromptSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Also, I didn't see anything to handle lint warnings. The spec is that we display an error if present, then a warning. |
a-b-r-o-w-n
suggested changes
Dec 3, 2019
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/fields/PromptField/PromptSettings.tsx
Outdated
Show resolved
Hide resolved
7 tasks
bf53c6c to
c8f95dd
Compare
needed to get error UI
a-b-r-o-w-n
approved these changes
Dec 4, 2019
Contributor
|
Note: What this change does not do is surface errors for any arbitrary field in the form. Only LG, LU and expression errors are surfaced right now. |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align with the new design in form for inline error display
Discussion
Task Item
closes #1623
Type of change
Please delete options that are not relevant.
Checklist
Screenshots