Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@cwhitten
Copy link
Member

@cwhitten cwhitten commented Nov 29, 2019

refs #1674

This change introduces a script to parse the local git branch and use it to do sha inspection of the corresponding remote branch. I've added a RELEASE_BRANCH guard to avoid unnecessary checks in development mode. This seems appropriate for now.

I've added execution of the script inside both build and startall.

Screen Shot 2019-11-29 at 12 54 09 PM

Screen Shot 2019-11-29 at 12 53 48 PM

@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.432% when pulling 8230118 on cwhitten/update into ae7fa1d on master.

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Only thought is why not prompt and update on the user's behalf?

@boydc2014
Copy link
Contributor

💯 Only thought is why not prompt and update on the user's behalf?

because it might break user's current bots? :)

@cwhitten
Copy link
Member Author

cwhitten commented Dec 2, 2019

💯 Only thought is why not prompt and update on the user's behalf?

because it might break user's current bots? :)

Yes, this was my thinking.

@cwhitten cwhitten merged commit 9bfd927 into master Dec 2, 2019
@cwhitten cwhitten deleted the cwhitten/update branch December 2, 2019 16:27
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants