feat: Start Botproject runtime in bot folder

[VanyLaw]

Description

This PR is for starting runtime by csharp botproject in bot folder rather than by common botproject.

Solution

1. When a call to /connect api. Check whether the port 3979 has been used. If port is valid, use it as the endpoint to start runtime, otherwise use another valid port instead.
2. Check whether the .net core version >=3.0, init user secret and build runtime.
3. Stop previous bot runtime and start current bot runtime.

Task Item

related to #1516
close #483

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Doc update (document update)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

[github-actions]

Coverage decreased (-0.08%) to 39.937% when pulling 6b04384 on wenyluo/csConnector into f492bef on master.

[compulim]

I am seeing a lot of coalesce of SensitiveProperties.

You can also consider coalesce at earlier code to reduce these coalesces.

[VanyLaw]

We shouldn't combine dockerfile for Composer and C# runtime because we'll have multiple languages for runtimes. If we need to have 1 container which runs both (which I think we should avoid), then we should build the composer container, then have the dotnet one extend the base composer container. That pattern would work for other language as well.

Hi @christopheranderson , Is there a solution for the "dockerfile spliting" problem? Like I said before, I have a build error when using two dockerfile, so, Is that ok to use multi-stage instead?

[cwhitten]

@VanyLaw have any commands changed to make this work? I'm seeing errors locally, but may be in a bad state:

~/src/BotFramework-Composer/Composer (wenyluo/csConnector) $ docker-compose build
Building composer
Step 1/27 : FROM node:12-alpine as build
 ---> 69c8cc9212ec
Step 2/27 : WORKDIR /src/Composer
 ---> Using cache
 ---> 71bb946b33f5
Step 3/27 : COPY . .
 ---> Using cache
 ---> 7f2deaf0fbd6
Step 4/27 : RUN yarn install --frozen-lock-file
 ---> Using cache
 ---> 2c35707c2fe0
Step 5/27 : ENV NODE_OPTIONS "--max-old-space-size=4096"
 ---> Using cache
 ---> f9d9d45b2d56
Step 6/27 : ENV NODE_ENV "production"
 ---> Using cache
 ---> d9984da779af
Step 7/27 : RUN yarn build:prod
 ---> Running in 45d73df91d2d
yarn run v1.19.1
$ yarn build:dev && yarn build:server && yarn build:client
$ yarn build:tools && yarn build:lib && yarn build:extensions
$ yarn workspace @bfc/tools build:all
$ concurrently --kill-others-on-fail "yarn:build:language-servers"
[build:language-servers] $ cd language-servers && yarn build
[build:language-servers] $ yarn build:lg
[build:language-servers] $ cd language-generation && yarn build
[build:language-servers] $ tsc --build tsconfig.build.json
[build:language-servers] yarn run build:language-servers exited with code 0
$ yarn workspace @bfc/libs build:all
$ yarn build:indexers && yarn build:shared && yarn build:code-editor
$ cd indexers && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ cd shared && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ cd code-editor && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ yarn workspace @bfc/extensions build:all
$ concurrently --kill-others-on-fail "yarn:build:obiformeditor" "yarn:build:visual-designer"
[build:obiformeditor] $ cd obiformeditor && yarn build
[build:visual-designer] $ cd visual-designer && yarn build
[build:obiformeditor] $ yarn clean && yarn build:css && yarn build:ts
[build:visual-designer] $ yarn clean && yarn build:css && yarn build:ts
[build:obiformeditor] $ rimraf lib demo/dist
[build:visual-designer] $ rimraf lib demo/dist
[build:obiformeditor] $ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
[build:visual-designer] $ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
[build:visual-designer] $ tsc --build tsconfig.build.json
[build:obiformeditor] $ tsc --build tsconfig.build.json
[build:visual-designer] yarn run build:visual-designer exited with code 0
[build:obiformeditor] yarn run build:obiformeditor exited with code 0
$ yarn workspace @bfc/server build
$ tsc -p tsconfig.build.json
$ yarn workspace @bfc/client build
$ node scripts/build.js
Creating an optimized production build. This may take a few minutes..
error Command failed with signal "SIGKILL".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /usr/local/bin/node
Arguments: /opt/yarn-v1.19.1/lib/cli.js build
Directory: /src/Composer/packages/client
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: Service 'composer' failed to build: The command '/bin/sh -c yarn build:prod' returned a non-zero code: 1

[boydc2014]

@VanyLaw have any commands changed to make this work? I'm seeing errors locally, but may be in a bad state:

~/src/BotFramework-Composer/Composer (wenyluo/csConnector) $ docker-compose build
Building composer
Step 1/27 : FROM node:12-alpine as build
 ---> 69c8cc9212ec
Step 2/27 : WORKDIR /src/Composer
 ---> Using cache
 ---> 71bb946b33f5
Step 3/27 : COPY . .
 ---> Using cache
 ---> 7f2deaf0fbd6
Step 4/27 : RUN yarn install --frozen-lock-file
 ---> Using cache
 ---> 2c35707c2fe0
Step 5/27 : ENV NODE_OPTIONS "--max-old-space-size=4096"
 ---> Using cache
 ---> f9d9d45b2d56
Step 6/27 : ENV NODE_ENV "production"
 ---> Using cache
 ---> d9984da779af
Step 7/27 : RUN yarn build:prod
 ---> Running in 45d73df91d2d
yarn run v1.19.1
$ yarn build:dev && yarn build:server && yarn build:client
$ yarn build:tools && yarn build:lib && yarn build:extensions
$ yarn workspace @bfc/tools build:all
$ concurrently --kill-others-on-fail "yarn:build:language-servers"
[build:language-servers] $ cd language-servers && yarn build
[build:language-servers] $ yarn build:lg
[build:language-servers] $ cd language-generation && yarn build
[build:language-servers] $ tsc --build tsconfig.build.json
[build:language-servers] yarn run build:language-servers exited with code 0
$ yarn workspace @bfc/libs build:all
$ yarn build:indexers && yarn build:shared && yarn build:code-editor
$ cd indexers && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ cd shared && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ cd code-editor && yarn build
$ yarn clean && yarn build:css && yarn build:ts
$ rimraf lib demo/dist
$ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
$ tsc --build tsconfig.build.json
$ yarn workspace @bfc/extensions build:all
$ concurrently --kill-others-on-fail "yarn:build:obiformeditor" "yarn:build:visual-designer"
[build:obiformeditor] $ cd obiformeditor && yarn build
[build:visual-designer] $ cd visual-designer && yarn build
[build:obiformeditor] $ yarn clean && yarn build:css && yarn build:ts
[build:visual-designer] $ yarn clean && yarn build:css && yarn build:ts
[build:obiformeditor] $ rimraf lib demo/dist
[build:visual-designer] $ rimraf lib demo/dist
[build:obiformeditor] $ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
[build:visual-designer] $ copyfiles --up 1 "src/**/*.css" "src/**/*.scss" lib
[build:visual-designer] $ tsc --build tsconfig.build.json
[build:obiformeditor] $ tsc --build tsconfig.build.json
[build:visual-designer] yarn run build:visual-designer exited with code 0
[build:obiformeditor] yarn run build:obiformeditor exited with code 0
$ yarn workspace @bfc/server build
$ tsc -p tsconfig.build.json
$ yarn workspace @bfc/client build
$ node scripts/build.js
Creating an optimized production build. This may take a few minutes..
error Command failed with signal "SIGKILL".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /usr/local/bin/node
Arguments: /opt/yarn-v1.19.1/lib/cli.js build
Directory: /src/Composer/packages/client
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: Service 'composer' failed to build: The command '/bin/sh -c yarn build:prod' returned a non-zero code: 1

Looks highly likely a memory issue, can you check did you alloc enough memory to docker-compose? In windows, the correct way to do that is

you need to make sure your memory is set to more than 4GB, the value we set on node.js limitation.

[VanyLaw]

Hi @cwhitten, The error was throw when client build, it seems like a out of memory issue, maybe extending the memory for docker can fix it.

[a-b-r-o-w-n]

Composer/packages/server/ComposerDialogs/settings/appsettings.json keeps getting created when launching or restarting the bot. Not sure what is happening.

[a-b-r-o-w-n]

Other than that one thing, this is looking good to me.

[VanyLaw]

Composer/packages/server/ComposerDialogs/settings/appsettings.json keeps getting created when launching or restarting the bot. Not sure what is happening.

Hi @a-b-r-o-w-n , I debug and find it's because I get the localStorage setting in sync api. but EnvironmentProvider.getCurrent() return the default environment which used null basePath, instead of the current botproject environment.

So I used BotProjectService.getCurrentBotProject()?.environment instead to fix it.

stale