Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: e2e failed #1671

Closed
lei9444 wants to merge 2 commits into from
Closed

fix: e2e failed #1671

lei9444 wants to merge 2 commits into from

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented Nov 28, 2019 •
edited
Loading

Description

when run test:integration:clean, the directory is different from the env.COMPOSER_BOTS_FOLDER.
The new bot may have conflict when the name is the same.

Task Item

refs #1652

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@lei9444 lei9444 changed the title update the e2e env.COMPOSER_BOTS_FOLDER fix: update the e2e env.COMPOSER_BOTS_FOLDER Nov 28, 2019
@lei9444 lei9444 changed the title fix: update the e2e env.COMPOSER_BOTS_FOLDER fix: e2e failed Nov 28, 2019
@lei9444 lei9444 closed this Nov 29, 2019
@lei9444
Copy link
Contributor Author

lei9444 commented Nov 29, 2019

move this to #1529

@lei9444 lei9444 deleted the e2e branch January 17, 2020 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten will be requested when the pull request is marked ready for review cwhitten is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 will be requested when the pull request is marked ready for review boydc2014 is a code owner

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n will be requested when the pull request is marked ready for review a-b-r-o-w-n is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath will be requested when the pull request is marked ready for review srinaath is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lei9444