Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

ci: correctly clean up server process after e2e tests #1666

Merged
a-b-r-o-w-n merged 3 commits into from
Nov 26, 2019
Merged

ci: correctly clean up server process after e2e tests #1666

a-b-r-o-w-n merged 3 commits into from
Nov 26, 2019

Conversation

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Nov 26, 2019

using KILL does not actually kill all child processes of yarn start

refs #1559

@a-b-r-o-w-n
use TERM signal to kill server on exit
8c1c3f4 
using KILL does not actually kill all child processes of `yarn start`
@a-b-r-o-w-n a-b-r-o-w-n merged commit f492bef into microsoft:master Nov 26, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-e2e-script branch November 26, 2019 22:48
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-b-r-o-w-n @cwhitten