Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

chore: enforce node >=12 #1665

Merged
cwhitten merged 3 commits into from
Nov 26, 2019
Merged

chore: enforce node >=12 #1665

cwhitten merged 3 commits into from
Nov 26, 2019

Conversation

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Nov 26, 2019

Node 12 is the current active LTS. People have been experiencing build issues (out of memory, etc) with node versions less than 12. So our advice is to update to a newer version of node. This enforces that through the package.json engines directive.

closes #1664

@cwhitten cwhitten merged commit 3609b4e into microsoft:master Nov 26, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the update-node-version branch November 26, 2019 22:14
@cwhitten cwhitten mentioned this pull request Nov 27, 2019
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@yeze322 yeze322 Awaiting requested review from yeze322

1 more reviewer

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-b-r-o-w-n @cwhitten