fix: dialog name incorrect when creating new dialog in form editor

[alanlong9278]

Description

Wrong behavior

the BeginDialog action can not get the dialog name after the user create a new one from the form. But there is a new beginDialog action with the dialog name in the new dialog trigger steps.

root cause

in createDialogBase function, it jumps to new dialog after creating the dialog, but the operation that setting the dialog name to the old beginDialog action is in the createDialog promise then function. So the operation in formEditor takes place in the new dialog page.

Solution

Move navTo function from createDialogBase to formEditor function.
createDialogBase just deals with the data logic.

Task Item

closes #1144

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Doc update (document update)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have functionally tested my change

Screenshots

[github-actions]

Coverage increased (+0.004%) to 39.823% when pulling 010afb9 on julong/beginDialog into f0ebe56 on master.

[a-b-r-o-w-n]

I still see a flicker when creating a dialog from the form.