Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented Nov 15, 2019

Description

  1. Onboarding is set disabled by default. Make it enable before testing.
  2. LgPage can't find the button.

closes #1592

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@cwhitten cwhitten changed the title fix: E2E test Onboarding and LgPage fix: E2E test Onboarding and LgPage (closes #1592) Nov 15, 2019
@cwhitten cwhitten changed the title fix: E2E test Onboarding and LgPage (closes #1592) fix: E2E test Onboarding and LgPage Nov 15, 2019
@cwhitten cwhitten merged commit 6c237a8 into microsoft:master Nov 15, 2019
@lei9444 lei9444 deleted the test branch January 17, 2020 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants