Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@liweitian
Copy link
Contributor

Description

update trigger name Conversation started to Greeting (ConversationUpdate)

Task Item

Closes #1302

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@boydc2014
Copy link
Contributor

Looks good. Looks like you updated all the references, code, doc, sample, pretty thoughtful. Just want to confirm one thing, only 3 templates are using OnConverstaionUpdate right?

@liweitian
Copy link
Contributor Author

Looks good. Looks like you updated all the references, code, doc, sample, pretty thoughtful. Just want to confirm one thing, only 3 templates are using OnConverstaionUpdate right?

Did a global search. So yes. Only three templates are using it.

@liweitian liweitian changed the title Liweitian/update trigger name [fix] update trigger name Nov 15, 2019
@liweitian liweitian changed the title [fix] update trigger name fix: update trigger name Nov 19, 2019
@cwhitten cwhitten merged commit 2151667 into master Nov 19, 2019
@cwhitten cwhitten deleted the liweitian/updateTriggerName branch November 19, 2019 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants