Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented Nov 14, 2019

Description

Implement 'destructor' in shared lib by following the same pattern with 'Copy Constructor'

Task Item

closes #1213

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@yeze322 yeze322 changed the title chore: Destructor in shared lib to remove LG resources during node deletion chore: Destructor in shared lib for removing LG templates during node deletion Nov 15, 2019
@cwhitten cwhitten changed the title chore: Destructor in shared lib for removing LG templates during node deletion chore: Destructor in shared lib for removing LG templates during node deletion (#1213) Nov 15, 2019
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a CI failure

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 18, 2019

there's a CI failure

Fixed those broken test cases

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 19, 2019

resolves the CI failure

@cwhitten cwhitten merged commit aa4ce70 into microsoft:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants