This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: update default bots folder #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
liweitian
force-pushed
the
liweitian/updateDefaultFolder
branch
from
eee3744 to
620d3fb
Compare
a-b-r-o-w-n
changed the title
a-b-r-o-w-n
approved these changes
Nov 12, 2019
| this.storageConnections = Store.get(this.STORE_KEY); | ||
| this.storageConnections.forEach(s => { | ||
| this.createFolderRecurively(s.defaultPath); | ||
| }); |
Contributor
There was a problem hiding this comment.
What if the user has changed their default folder and then deleted the one we create? Won't this create /Documents/Composer every time?
Contributor
Author
There was a problem hiding this comment.
the default path is set in file data.template.json. It does not allow users to change it. These lines of code is to make sure the default path is always valid.
a-b-r-o-w-n
previously requested changes
Nov 13, 2019
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
I have some questions about edge cases.
liweitian
force-pushed
the
liweitian/updateDefaultFolder
branch
from
8044e2b to
d0eb0b2
Compare
boydc2014
reviewed
Nov 15, 2019
| if (fs.existsSync(s.path)) { | ||
| temp.path = Path.resolve(s.path); // resolve path if path is relative, and change it to unix pattern | ||
| } else { | ||
| this.createDefaultBotFolders(); |
Contributor
There was a problem hiding this comment.
you are creating all folders inside a for loop. It's a O(n2) operation.
my suggestion is call this method "ensureFolderExisit", and put this after this map.
Member
|
@liweitian there is a lint failure |
liweitian
force-pushed
the
liweitian/updateDefaultFolder
branch
from
c6468d5 to
eb0cde2
Compare
cwhitten
approved these changes
Nov 19, 2019
This was referenced Nov 19, 2019
a-b-r-o-w-n
pushed a commit
that referenced
this pull request
Nov 20, 2019
This reverts commit 8f2bc2e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
Closes #1506
Closes #1363
Type of change
Bug fix (non-breaking change which fixes an issue)