This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
Refine LG Template API #1512
Merged
Merged
Refine LG Template API #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This pr #1349 lost fork information, move to here |
6 tasks
Contributor
Author
|
@yeze322 Added couple of methods: and applied to visual editor |
Contributor
|
|
Contributor
|
Changes on |
9 tasks
9 tasks
Contributor
boydc2014
reviewed
Nov 11, 2019
cwhitten
reviewed
Nov 11, 2019
boydc2014
previously approved these changes
Nov 12, 2019
Contributor
Looks good, and can you add those signature into comments of code at somewhere? |
Contributor
Author
Yes, added to lgUtils.ts |
Contributor
Author
|
@boydc2014 can it be merged? |
boydc2014
reviewed
Nov 12, 2019
Composer/packages/client/src/pages/language-generation/table-view.js
Outdated
Show resolved
Hide resolved
boydc2014
approved these changes
Nov 12, 2019
Contributor
|
Looks good. |
Contributor
Contributor
|
Thanks to everyone! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
fix #1211
fix #1213
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.