chore: copy Constructor in 'shared' lib

Composer/packages/extensions/obiformeditor/__tests__/Form/ArrayFieldTemplate/IDialogArray.test.tsx

@@ -74,12 +74,14 @@ describe('<IDialogArray />', () => {
         id: expect.any(String),
         name: 'Send a response',
       },
+      activity: '',
       data: {
         $type: 'Microsoft.SendActivity',
         $designer: {
           id: expect.any(String),
           name: 'Send a response',
         },
+        activity: '',
       },
       key: 'Microsoft.SendActivity',
       name: 'Send a response',

Composer/packages/extensions/visual-designer/src/editors/ObiEditor.tsx

@@ -45,10 +45,9 @@ export const ObiEditor: FC<ObiEditorProps> = ({
 }): JSX.Element | null => {
   let divRef;
 
-  const { focusedId, focusedEvent, clipboardActions, updateLgTemplate, getLgTemplates, removeLgTemplates } = useContext(
+  const { focusedId, focusedEvent, clipboardActions, copyLgTemplate, removeLgTemplates } = useContext(
     NodeRendererContext
   );
-  const lgApi = { getLgTemplates, removeLgTemplates, updateLgTemplate };
   const dispatchEvent = (eventName: NodeEventTypes, eventData: any): any => {
     let handler;
     switch (eventName) {
@@ -107,7 +106,19 @@ export const ObiEditor: FC<ObiEditorProps> = ({
       case NodeEventTypes.Insert:
         if (eventData.$type === 'PASTE') {
           handler = e => {
-            pasteNodes(data, e.id, e.position, clipboardActions, lgApi).then(dialog => {
+            // TODO: clean this along with node deletion.
+            const copyLgTemplateToNewNode = async (lgTemplateName: string, newNodeId: string) => {
+              const matches = /\[(bfd\w+-(\d+))\]/.exec(lgTemplateName);
+              if (Array.isArray(matches) && matches.length === 3) {
+                const originLgId = matches[1];
+                const originNodeId = matches[2];
+                const newLgId = originLgId.replace(originNodeId, newNodeId);
+                await copyLgTemplate('common', originLgId, newLgId);
+                return `[${newLgId}]`;
+              }
+              return lgTemplateName;
+            };
+            pasteNodes(data, e.id, e.position, clipboardActions, copyLgTemplateToNewNode).then(dialog => {
               onChange(dialog);
             });
           };

Composer/packages/extensions/visual-designer/src/index.tsx

@@ -53,6 +53,7 @@ const VisualDesigner: React.FC<VisualDesignerProps> = ({
     saveData,
     updateLgTemplate,
     getLgTemplates,
+    copyLgTemplate,
     removeLgTemplate,
     removeLgTemplates,
     undo,
@@ -69,6 +70,7 @@ const VisualDesigner: React.FC<VisualDesignerProps> = ({
     clipboardActions: clipboardActions || [],
     updateLgTemplate,
     getLgTemplates,
+    copyLgTemplate,
     removeLgTemplate,
     removeLgTemplates,
   });

Composer/packages/extensions/visual-designer/src/store/NodeRendererContext.ts

@@ -14,6 +14,7 @@ export const NodeRendererContext = React.createContext({
   focusedTab: '',
   clipboardActions: [] as any[],
   getLgTemplates: (_id: string, _templateName: string) => Promise.resolve([] as LgTemplate[]),
+  copyLgTemplate: (_id: string, _fromTemplateName: string, _toTemplateName: string) => Promise.resolve(''),
   removeLgTemplate: (_id: string, _templateName: string) => Promise.resolve(),
   removeLgTemplates: (_id: string, _templateNames: string[]) => Promise.resolve(),
   updateLgTemplate: (_id: string, _templateName: string, _template: string) => Promise.resolve('' as string),

Composer/packages/extensions/visual-designer/src/utils/jsonTracker.ts

@@ -201,7 +201,7 @@ export function appendNodesAfter(inputDialog, targetId, newNodes) {
   return dialog;
 }
 
-export async function pasteNodes(inputDialog, arrayPath, arrayIndex, newNodes, lgApi) {
+export async function pasteNodes(inputDialog, arrayPath, arrayIndex, newNodes, copyLgTemplate) {
   if (!Array.isArray(newNodes) || newNodes.length === 0) {
     return inputDialog;
   }
@@ -219,7 +219,7 @@ export async function pasteNodes(inputDialog, arrayPath, arrayIndex, newNodes, l
   const copiedNodes: any[] = [];
   for (const node of newNodes) {
     // Deep copy nodes with external resources
-    const copy = await deepCopyAction(node, lgApi);
+    const copy = await deepCopyAction(node, copyLgTemplate);
     copiedNodes.push(copy);
   }
 

Composer/packages/lib/shared/__tests__/copyUtils/copyAdaptiveAction.test.ts

@@ -0,0 +1,51 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { externalApiStub as externalApi } from '../jestMocks/externalApiStub';
+import { SDKTypes } from '../../src';
+import CopyConstructorMap from '../../src/copyUtils/CopyConstructorMap';
+import { copyAdaptiveAction } from '../../src/copyUtils';
+
+// NOTES: Cannot use SDKTypes here. `jest.mock` has to have zero dependency.
+jest.mock('../../src/copyUtils/CopyConstructorMap', () => ({
+  'Microsoft.SendActivity': jest.fn(),
+  'Microsoft.IfCondition': jest.fn(),
+  'Microsoft.SwitchCondition': jest.fn(),
+  'Microsoft.EditActions': jest.fn(),
+  'Microsoft.ChoiceInput': jest.fn(),
+  'Microsoft.Foreach': jest.fn(),
+  default: jest.fn(),
+}));
+
+describe('copyAdaptiveAction', () => {
+  it('should return {} when input is invalid', async () => {
+    expect(await copyAdaptiveAction('hello', externalApi)).toEqual('hello');
+
+    expect(await copyAdaptiveAction(null as any, externalApi)).toEqual({});
+    expect(await copyAdaptiveAction({} as any, externalApi)).toEqual({});
+    expect(await copyAdaptiveAction({ name: 'hi' } as any, externalApi)).toEqual({});
+  });
+
+  const registeredTypes = [
+    SDKTypes.SendActivity,
+    SDKTypes.IfCondition,
+    SDKTypes.SwitchCondition,
+    SDKTypes.EditActions,
+    SDKTypes.ChoiceInput,
+    SDKTypes.Foreach,
+  ];
+  for (const $type of registeredTypes) {
+    it(`should invoke registered handler for ${$type}`, async () => {
+      await copyAdaptiveAction({ $type }, externalApi);
+      expect(CopyConstructorMap[$type]).toHaveReturnedTimes(1);
+    });
+  }
+
+  it('should invoke default handler for other types', async () => {
+    await copyAdaptiveAction({ $type: SDKTypes.BeginDialog }, externalApi);
+    expect(CopyConstructorMap.default).toHaveReturnedTimes(1);
+
+    await copyAdaptiveAction({ $type: SDKTypes.HttpRequest }, externalApi);
+    expect(CopyConstructorMap.default).toHaveReturnedTimes(2);
+  });
+});

Composer/packages/lib/shared/__tests__/copyUtils/copyEditActions.test.ts

@@ -0,0 +1,37 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { copyEditActions } from '../../src/copyUtils/copyEditActions';
+import { externalApiStub as externalApi } from '../jestMocks/externalApiStub';
+
+describe('#copyEditActions', () => {
+  it('can copy EditActions', async () => {
+    const editActions = {
+      $type: 'Microsoft.EditActions',
+      changeType: 'InsertActions',
+      actions: [
+        {
+          $type: 'Microsoft.BeginDialog',
+          dialog: 'AddToDo',
+        },
+      ],
+    };
+
+    expect(await copyEditActions(editActions, externalApi)).toEqual({
+      $type: 'Microsoft.EditActions',
+      $designer: {
+        id: '5678',
+      },
+      changeType: 'InsertActions',
+      actions: [
+        {
+          $type: 'Microsoft.BeginDialog',
+          $designer: {
+            id: '5678',
+          },
+          dialog: 'AddToDo',
+        },
+      ],
+    });
+  });
+});

Composer/packages/lib/shared/__tests__/copyUtils/copyForeach.test.ts

@@ -0,0 +1,69 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License
+
+import { copyForeach } from '../../src/copyUtils/copyForeach';
+import { externalApiStub as externalApi } from '../jestMocks/externalApiStub';
+
+describe('#copyForeach', () => {
+  it('can copy Foreach action', async () => {
+    const foreachInstance = {
+      $type: 'Microsoft.Foreach',
+      itemsProperty: 'name',
+      actions: [
+        {
+          $type: 'Microsoft.SendActivity',
+          activity: 'hello',
+        },
+      ],
+    };
+
+    expect(await copyForeach(foreachInstance, externalApi)).toEqual({
+      $type: 'Microsoft.Foreach',
+      itemsProperty: 'name',
+      $designer: {
+        id: '5678',
+      },
+      actions: [
+        {
+          $type: 'Microsoft.SendActivity',
+          $designer: {
+            id: '5678',
+          },
+          activity: 'hello',
+        },
+      ],
+    });
+  });
+
+  it('can copy ForeachPage action', async () => {
+    const foreachPageInstance = {
+      $type: 'Microsoft.Foreach',
+      itemsProperty: 'name',
+      pageSize: 10,
+      actions: [
+        {
+          $type: 'Microsoft.SendActivity',
+          activity: 'hello',
+        },
+      ],
+    };
+
+    expect(await copyForeach(foreachPageInstance, externalApi)).toEqual({
+      $type: 'Microsoft.Foreach',
+      itemsProperty: 'name',
+      pageSize: 10,
+      $designer: {
+        id: '5678',
+      },
+      actions: [
+        {
+          $type: 'Microsoft.SendActivity',
+          $designer: {
+            id: '5678',
+          },
+          activity: 'hello',
+        },
+      ],
+    });
+  });
+});