Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented Oct 28, 2019

Description

In a TextInput (and other inputs) action, there might be 4 possible fields using lg template:

  1. 'prompt'
  2. 'unrecognizedPrompt'
  3. 'defaultValueResponse'
  4. 'invalidPrompt'

In this PR, make the copier handling all 4 kinds of field names.

Fixes #1191

Task Item

#1191

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

copy-prompt

@a-b-r-o-w-n a-b-r-o-w-n merged commit 3fc0af3 into master Oct 28, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the zeye/lg/copy-prompts branch October 28, 2019 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants