Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Fix #1214 by checking empty array before accessing it #1215

Merged
cwhitten merged 1 commit into from
Oct 23, 2019
Merged

Fix #1214 by checking empty array before accessing it #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Composer/packages/client/src/CreationFlow/DefineConversation/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ export function DefineConversation(props) {
// set the default path
useEffect(() => {
const index = currentStorageIndex.current;
updateForm('location')(null, storages[index].path);
if (storages[index]) {
Copy link
Contributor

@boydc2014 boydc2014 Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this did fixed the issue, approving it now, but @liweitian can you confirm, why we are checking storages here when "creating dialog"

Copy link
Contributor

@boydc2014 boydc2014 Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also @lei9444 please review the design of this component here.

Copy link
Contributor

@boydc2014 boydc2014 Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it's because this control is shared between "creating bot" and "creating dialog"

Copy link
Member

@cwhitten cwhitten Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will take this for now but I echo Dong's questions - let's understand this a bit more

updateForm('location')(null, storages[index].path);
}
}, [storages]);

const updateForm = field => (e, newValue) => {
Expand Down