[WIP] LG activity copy behavior: copies all possible lg templates

Composer/packages/lib/shared/__tests__/copyUtils.test.ts

@@ -1,7 +1,11 @@
 import { copyAdaptiveAction } from '../src/copyUtils';
 
 describe('copyAdaptiveAction', () => {
-  const lgTemplate = [{ Name: 'bfdactivity-1234', Body: '-hello' }];
+  const lgTemplate = [
+    { Name: 'bfdactivity-1234', Body: '-hello' },
+    { Name: 'bfdprompt-1234', Body: '-prompt' },
+    { Name: 'bfdinvalidPrompt-1234', Body: '-invalid' },
+  ];
   const externalApi = {
     updateDesigner: data => {
       data.$designer = { id: '5678' };
@@ -72,7 +76,8 @@ describe('copyAdaptiveAction', () => {
       alwaysPrompt: false,
       allowInterruptions: 'true',
       outputFormat: 'none',
-      prompt: '[bfdactivity-1234]',
+      prompt: '[bfdprompt-1234]',
+      invalidPrompt: '[bfdinvalidPrompt-1234]',
     };
 
     expect(await copyAdaptiveAction(promptText, externalApi)).toEqual({
@@ -84,7 +89,8 @@ describe('copyAdaptiveAction', () => {
       alwaysPrompt: false,
       allowInterruptions: 'true',
       outputFormat: 'none',
-      prompt: '[bfdactivity-5678]',
+      prompt: '[bfdprompt-5678]',
+      invalidPrompt: '[bfdinvalidPrompt-5678]',
     });
 
     expect(await copyAdaptiveAction(promptText, externalApiWithFailure)).toEqual({
@@ -96,7 +102,8 @@ describe('copyAdaptiveAction', () => {
       alwaysPrompt: false,
       allowInterruptions: 'true',
       outputFormat: 'none',
-      prompt: '-hello',
+      prompt: '-prompt',
+      invalidPrompt: '-invalid',
     });
   });
 });

Composer/packages/lib/shared/src/copyUtils.ts

@@ -37,11 +37,12 @@ async function walkAdaptiveAction(input: any, visitor: (data: any) => Promise<an
   }
 }
 
+const LgActivityRegex = /\[bfd.+-.+\]/;
 function isLgActivity(activity: string) {
-  return activity && (activity.includes('bfdactivity-') || activity.includes('bfdprompt-'));
+  return activity && LgActivityRegex.test(activity);
 }
 
-async function copyLgActivity(activity: string, designerId: string, lgApi: any): Promise<string> {
+async function copyLgActivity(activity: string, newLgId: string, lgApi: any): Promise<string> {
   if (!activity) return '';
   if (!isLgActivity(activity) || !lgApi) return activity;
 
@@ -60,7 +61,6 @@ async function copyLgActivity(activity: string, designerId: string, lgApi: any):
   if (currentLg) {
     // Create new lg activity.
     const newLgContent = currentLg.Body;
-    const newLgId = `bfdactivity-${designerId}`;
     try {
       await updateLgTemplate('common', newLgId, newLgContent);
       return `[${newLgId}]`;
@@ -72,11 +72,18 @@ async function copyLgActivity(activity: string, designerId: string, lgApi: any):
 }
 
 const overrideLgActivity = async (data, { lgApi }) => {
-  data.activity = await copyLgActivity(data.activity, data.$designer.id, lgApi);
+  const newLgId = `bfdactivity-${data.$designer.id}`;
+  data.activity = await copyLgActivity(data.activity, newLgId, lgApi);
 };
 
 const overrideLgPrompt = async (data, { lgApi }) => {
-  data.prompt = await copyLgActivity(data.prompt, data.$designer.id, lgApi);
+  for (const promptFieldKey of ['prompt', 'unrecognizedPrompt', 'invalidPrompt', 'defaultValueResponse']) {
+    const existingActivity = data[promptFieldKey];
+    const newLgId = `bfd${promptFieldKey}-${data.$designer.id}`;
+    if (existingActivity) {
+      data[promptFieldKey] = await copyLgActivity(existingActivity, newLgId, lgApi);
+    }
+  }
 };
 
 // TODO: use $type from SDKTypes (after solving circular import issue).