A folder with the name '&' shows blank in the 'Recent locations' dropdown list

[v-limu]

Storage Explorer Version: 1.17.0
Build: 20201222.4
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu16.04 / MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression

Steps to Reproduce

1. Expand one storage account -> File Shares.
2. Create a file share -> Click 'New Folder' -> Input '&' as the new folder name -> Click 'OK'.
3. Open the folder -> Click 'Recent locations'.
4. Check whether the folder name '&' shows in the 'Recent locations' dropdown list.

Expected Experience

The folder name '&' shows well in the 'Recent locations' dropdown list.

Actual Experience

The folder name shows blank in the 'Recent locations' dropdown list.

More Info:
This issue also reproduces for one blob container.

[craxal]

This is an Electron issue, which can be tracked here: electron/electron#25028.

[craxal]

Electron folks are updating their documentation. We can escape the & with another &.

[v-xianya]

Hi @craxal
Verified this issue on build 20210223.2. There are some problems on this scenario.
We are going to re-open it. Could you help to take a look?

The folder named '&&' show as '&' under the recent locations;

The folder named '&&&&' show as '&&' under the recent locations;

[craxal]

Argh! Apparently String.replace rather unintuitively replaces the first occurrence of the pattern unless the pattern is a global regular expression. In other words:

"&&".replace("&", "&&"); // Returns "&&&", not what we want
"&&".replace(/&/g, "&&"); // Returns "&&&&", which is what we want

Change has been merged.